docs(openhab): sync template standards updates#352
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a ChangesOpenHAB podLabels support
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - Align openHAB StatefulSet pod template labels with immutable selector labels plus user `podLabels`. - Add fail-fast validation to prevent `podLabels` from overriding selector labels. - Add unit coverage for selector-label override validation. ## Validation - `helm unittest charts/openhab`: 118 tests passed - `helm lint --strict charts/openhab`: passed - `make template-standards-check CHART=openhab`: passed - `make standards-check CHART=openhab`: passed - `make standards-guard CHART=openhab`: passed - `node scripts/charts/validate-chart.js --chart openhab --no-k3d`: static layers passed, including kubeconform and ah lint - k3d behavioral validation on `k3d-helmforge-tests-wsl`: default plus every `ci/*.yaml` passed sequentially - `make site-sync-check CHART=openhab`: passed - site `npm run lint`, `npm run format:check`, `npm run build`: passed - `make release-check REPO=charts`: passed with expected post-merge release warning - `make attribution-check REPO=charts`: passed ## Site Sync Site PR: helmforgedev/site#352 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Added validation to prevent custom pod labels from overriding required selector labels, avoiding invalid StatefulSet output. * Updated pod label rendering to consistently use the selector labels set for pods. * **Tests** * Expanded validation tests to cover conflicts for both selector label keys (name and instance). * Added dedicated test values to confirm rendering fails with the expected error message when conflicts occur. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
mberlofa
force-pushed
the
docs/openhab-template-standards-sync
branch
from
f96b819 to
ec4bb9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
podLabelsselector-label reservation.Related
Chart PR: helmforgedev/charts#674
Validation
make site-sync-check CHART=openhab: passednpm run lint: passednpm run format:check: passednpm run build: passedmake release-check REPO=site: passedmake attribution-check REPO=site: passedSummary by CodeRabbit
podLabelsoption for adding extra pod labels, while reserving selector labels (default{}).